Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

align extractModeSlider() and extractModeNames() behaviour

Browse Source 
* document behavior
* both functions are only called from usermods, and all calls are already correctly passing maxLen = buffersize -1
This commit is contained in:
Frank
2025-12-29 19:43:42 +01:00
parent dab6a96b78
commit 4521ba848c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wled00/util.cpp
View File

@@ -311,7 +311,7 @@ uint8_t extractModeName(uint8_t mode, const char *src, char *dest, uint8_t maxLe
} }
// extracts effect slider data (1st group after @) // extracts effect slider data (1st group after @) -> maxLen is (buffersize - 1)
uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxLen, uint8_t *var) uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxLen, uint8_t *var)
{ {
dest[0] = '\0'; // start by clearing buffer dest[0] = '\0'; // start by clearing buffer
@@ -378,7 +378,7 @@ uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxL
case 0: strncpy_P(dest, PSTR("FX Speed"), maxLen); break; case 0: strncpy_P(dest, PSTR("FX Speed"), maxLen); break;
case 1: strncpy_P(dest, PSTR("FX Intensity"), maxLen); break; case 1: strncpy_P(dest, PSTR("FX Intensity"), maxLen); break;
} }
dest[maxLen-1] = '\0'; // strncpy does not necessarily null terminate string dest[maxLen] = '\0'; // strncpy does not necessarily null terminate string
} }
} }
return strlen(dest); return strlen(dest);