From 4521ba848cf49d2f9f2a273266b4315f5caf14fa Mon Sep 17 00:00:00 2001
From: Frank <91616163+softhack007@users.noreply.github.com>
Date: Mon, 29 Dec 2025 19:43:42 +0100
Subject: [PATCH] align extractModeSlider() and extractModeNames() behaviour

* document behavior
* both functions are only called from usermods, and all calls are already correctly passing maxLen = buffersize -1
---
 wled00/util.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/wled00/util.cpp b/wled00/util.cpp
index 61aa0b4d..58f092ee 100644
--- a/wled00/util.cpp
+++ b/wled00/util.cpp
@@ -311,7 +311,7 @@ uint8_t extractModeName(uint8_t mode, const char *src, char *dest, uint8_t maxLe
 }
 
 
-// extracts effect slider data (1st group after @)
+// extracts effect slider data (1st group after @) -> maxLen is (buffersize - 1)
 uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxLen, uint8_t *var)
 {
   dest[0] = '\0'; // start by clearing buffer
@@ -378,7 +378,7 @@ uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxL
           case 0:  strncpy_P(dest, PSTR("FX Speed"), maxLen); break;
           case 1:  strncpy_P(dest, PSTR("FX Intensity"), maxLen); break;
         }
-        dest[maxLen-1] = '\0'; // strncpy does not necessarily null terminate string
+        dest[maxLen] = '\0'; // strncpy does not necessarily null terminate string
       }
     }
     return strlen(dest);