Merge remote-tracking branch 'origin/weather-usermod' into mdev

2022-10-16 11:02:29 +02:00
parent a9d09b9658 eb4aacdf8a
commit 1d55108690
1 changed files with 2 additions and 2 deletions
--- a/usermods/usermod_v2_weather/usermod_v2_weather.h
+++ b/usermods/usermod_v2_weather/usermod_v2_weather.h
@@ -54,8 +54,8 @@ uint16_t mode_2DWeather(void) {

  // Serial.print(" temp ");

-  char tempString[5] = "";
-  sprintf(tempString, "%5.2f", currentTemp);
+  char tempString[6] = { '\0' };  // initialize string with zeros
+  snprintf(tempString, 5, "%5.2f", currentTemp); // snprintf will prevent overflow
  // Serial.println();

  CRGB color = ColorFromPalette(SEGPALETTE, map((uint8_t)currentTemp, 0, 40, 0, 255), 255, LINEARBLEND);