Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

robustness: prevent negative transitions

Browse Source 
fix for a corner case that might lead to unexpected math overflow
This commit is contained in:
Frank
2025-01-17 21:36:51 +01:00
parent 2c0063dc5b
commit 0eec8e46c9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
wled00/led.cpp
View File

@@ -194,7 +194,7 @@ void handleTransitions()
if (transitionActive && transitionDelayTemp > 0) if (transitionActive && transitionDelayTemp > 0)
{ {
float tper = (millis() - transitionStartTime)/(float)transitionDelayTemp; float tper = (millis() - transitionStartTime)/(float)transitionDelayTemp;
if (tper >= 1.0f) if ((tper >= 1.0f) || (tper < 0.0f)) // WLEDMM also catch "<0" case, that may happen when millis() rolls over
{ {
strip.setTransitionMode(false); strip.setTransitionMode(false);
// restore (global) transition time if not called from UDP notifier or single/temporary transition from JSON (also playlist) // restore (global) transition time if not called from UDP notifier or single/temporary transition from JSON (also playlist)
@@ -207,7 +207,7 @@ void handleTransitions()
} }
if (tper - tperLast < 0.004f) return; if (tper - tperLast < 0.004f) return;
tperLast = tper; tperLast = tper;
briT = briOld + ((bri - briOld) * tper); briT = briOld + ((int(bri) - int(briOld)) * tper); // WLEDMM avoid undefined behaviour when briOld < bri
applyBri(); applyBri();
} }