Commit Graph

13 Commits

Author SHA1 Message Date
Frank Möhle
e6e2348483 protect start byte
If Channel is less than 0, it's clamped to 0 on line 134. Then on line 138, dmxData[0] is written with the value, overwriting the start byte that was just set on line 137. DMX Channel numbers should be 1-based (1-512). The bounds check should clamp Channel to a minimum of 1, not 0, to prevent corrupting the start byte

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-01-25 17:29:10 +01:00
Frank
8faa88e05b chanSize expansion must account for start byte 2026-01-25 17:02:06 +01:00
Frank
f0753d6cf6 robustness improvement
bounds check before changing global variables
2026-01-25 16:18:30 +01:00
Frank
2628e9167d fix max number of bytes to be sent 2026-01-25 16:15:24 +01:00
Frank
82f713093e indentation 2026-01-25 15:46:57 +01:00
Frank
fb738883fa safeguards against array bounds violation 2026-01-25 15:43:53 +01:00
Frank
900178cd70 only build DMX drivers when WLED_ENABLE_DMX
both ESPDMX and SparkFunDMX have their own global buffers. Conditional compile prevents that these buffers are consuming RAM when not needed.
2026-01-25 15:08:40 +01:00
Frank
6ad6acfe08 align DMX output drivers with upstream
imports a few DMX serial output improvement from upstream
2026-01-25 15:06:27 +01:00
Frank
cafa78c3f3 fixing CI build. really now.
-check IDF target after including arduino.h
-add missing build flags in [env:esp32s2_saola]
2022-12-10 19:00:48 +01:00
Frank
e808f7655c fix CI build
make sure SparkFunDMX driver is not compiled on -S2 and -C3
2022-12-10 18:20:00 +01:00
Frank
4f28bf7ab4 missing word in comment 2022-12-10 18:00:48 +01:00
Frank
9380b2b4e8 SparkFunDMX: fix for issue #2928
* make SparlFunDMX driver more robust:
- made variables static (so they don't overlap with other global variables)
- made sure all valriables are properly initialized
- do not apply pinMode and digitalRead to invalid pins (as this creates problems on -S3, -C3 and -S2)
* disable DMX sending code (unneeded code that may case troubles)
2022-12-10 17:55:14 +01:00
Luke Plassman
bef9c68f81 Working DMX Libraries (#2652)
* added SparkFunDMX library dependencies

* changed variable names to avoid conflicts with SparkFunDMX library

* board version checks

* minor changes to DMX

* fix brightness when no shutter DMX channel is set

* fix compile issue on newer ESP32 variants
2022-05-05 02:28:09 +02:00