Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix string overflow

Browse Source 
this fixes a string overflow. The "null" character did not fir into tempString, leading array-write-out-of-bounds.
This commit is contained in:
Frank
2022-10-13 20:23:06 +02:00
parent af3e250f76
commit eb4aacdf8a
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
usermods/usermod_v2_weather/usermod_v2_weather.h
View File

@@ -54,8 +54,8 @@ uint16_t mode_2DWeather(void) {
// Serial.print(" temp "); // Serial.print(" temp ");
char tempString[5] = ""; char tempString[6] = { '\0' }; // initialize string with zeros
sprintf(tempString, "%5.2f", currentTemp); snprintf(tempString, 5, "%5.2f", currentTemp); // snprintf will prevent overflow
// Serial.println(); // Serial.println();
CRGB color = ColorFromPalette(SEGPALETTE, map((uint8_t)currentTemp, 0, 40, 0, 255), 255, LINEARBLEND); CRGB color = ColorFromPalette(SEGPALETTE, map((uint8_t)currentTemp, 0, 40, 0, 255), 255, LINEARBLEND);