Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Bugfix: remove ghost pixels when changing segment options

Browse Source 
... transpose, mirror, reverse, grouping, spacing, size

* unlike AC WLED, when calling seg.fill(BLACK) from webserver context this usually has no effect --> added  markForBlank() that shedules segment blanking at the next drawing cycle
* fill previous segment with black when size, grouping or spacing changes
This commit is contained in:
Frank
2024-11-07 14:36:39 +01:00
parent bab415156b
commit d1541b520f
3 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
wled00/FX_fcn.cpp
View File

@@ -277,7 +277,16 @@ void Segment::resetIfRequired() {
next_time = 0; step = 0; call = 0; aux0 = 0; aux1 = 0;
reset = false; // setOption(SEG_OPTION_RESET, false);
startFrame(); // WLEDMM update cached propoerties
if (isActive()) fill(BLACK); // WLEDMM start clean
DEBUG_PRINTLN("Segment reset");
} else if (needsBlank) {
startFrame(); // WLEDMM update cached propoerties
if (isActive()) {
fill(BLACK); // WLEDMM start clean
DEBUG_PRINTLN("Segment blanked");
}
}
needsBlank = false;
}
void Segment::setUpLeds() {
@@ -510,7 +519,7 @@ void Segment::setUp(uint16_t i1, uint16_t i2, uint8_t grp, uint8_t spc, uint16_t
stateChanged = true; // send UDP/WS broadcast
if (stop>start) fill(BLACK); //turn old segment range off // WLEDMM stop > start
if (stop>start) markForBlank(); //turn old segment range off // WLEDMM stop > start
if (i2 <= i1) { //disable segment
stop = 0;
markForReset();
@@ -2310,6 +2319,7 @@ void WS2812FX::restartRuntime(bool doReset) {
seg.markForReset(); // seg.resetIfRequired(); // WLEDMM calling this function from webserver context will cause troubles
} else {
seg.next_time = 0; seg.step = 0;
seg.markForBlank();
}
}
}