Update guidelines for code review process
Added a guideline to justify or remove unused/dead code.
This commit is contained in:
1
.github/copilot-instructions.md
vendored
1
.github/copilot-instructions.md
vendored
@@ -69,6 +69,7 @@ Main development branch: `mdev`
|
|||||||
- **Acknowledge good patterns** when you see them. Summarize good practices as part of your review - positive feedback always helps.
|
- **Acknowledge good patterns** when you see them. Summarize good practices as part of your review - positive feedback always helps.
|
||||||
- **Provide references** when making analyses or recommendations. Base them on the correct branch or PR.
|
- **Provide references** when making analyses or recommendations. Base them on the correct branch or PR.
|
||||||
- **Look for user-visible "breaking" changes**. Ask for confirmation that these were made intentionally.
|
- **Look for user-visible "breaking" changes**. Ask for confirmation that these were made intentionally.
|
||||||
|
- **Unused / dead code must be justified or removed**. This helps to keep the codebase clean, maintainable and readable.
|
||||||
- **C++ formatting available**: `clang-format` is installed but not in CI
|
- **C++ formatting available**: `clang-format` is installed but not in CI
|
||||||
- No automated linting is configured — match existing code style in files you edit. See `cpp.instructions.md` and `web.instructions.md` for language-specific conventions, and `cicd.instructions.md` for GitHub Actions workflows.
|
- No automated linting is configured — match existing code style in files you edit. See `cpp.instructions.md` and `web.instructions.md` for language-specific conventions, and `cicd.instructions.md` for GitHub Actions workflows.
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user