Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

another attempt to prevent glitches caused by file access

Browse Source 
wait for LEDs send out to finish, then access presets.json
This commit is contained in:
Frank
2026-01-05 11:22:53 +01:00
parent f9c7828eeb
commit 586d3c2732
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wled00/file.cpp
View File

@@ -547,6 +547,12 @@ bool handleFileRead(AsyncWebServerRequest* request, String path){
} }
#endif #endif
// wait for strip to finish updating, accessing FS during sendout causes glitches
#ifdef ARDUINO_ARCH_ESP32
unsigned wait_start = millis();
while (strip.isUpdating() && (millis() - wait_start < 40)) delay(1); // wait max 40ms
#endif
if(WLED_FS.exists(path) || WLED_FS.exists(path + ".gz")) { if(WLED_FS.exists(path) || WLED_FS.exists(path + ".gz")) {
request->send(WLED_FS, path, String(), request->hasArg(F("download"))); request->send(WLED_FS, path, String(), request->hasArg(F("download")));
return true; return true;

12
wled00/presets.cpp
View File

@@ -49,6 +49,12 @@ static void doSaveState() {
return; return;
} }
// wait for strip to finish updating, accessing FS during sendout causes glitches
#ifdef ARDUINO_ARCH_ESP32
unsigned wait_start = millis();
while (strip.isUpdating() && (millis() - wait_start < 40)) delay(1); // wait max 40ms
#endif
initPresetsFile(); // just in case if someone deleted presets.json using /edit initPresetsFile(); // just in case if someone deleted presets.json using /edit
JsonObject sObj = doc.to<JsonObject>(); JsonObject sObj = doc.to<JsonObject>();
@@ -357,6 +363,12 @@ void savePreset(byte index, const char* pname, JsonObject sObj)
sObj.remove(F("psave")); sObj.remove(F("psave"));
if (sObj["n"].isNull()) sObj["n"] = saveName; if (sObj["n"].isNull()) sObj["n"] = saveName;
// wait for strip to finish updating, accessing FS during sendout causes glitches
#ifdef ARDUINO_ARCH_ESP32
unsigned wait_start = millis();
while (strip.isUpdating() && (millis() - wait_start < 40)) delay(1); // wait max 40ms
#endif
initPresetsFile(); // just in case if someone deleted presets.json using /edit initPresetsFile(); // just in case if someone deleted presets.json using /edit
writeObjectToFileUsingId(getFileName(index<255), index, fileDoc); writeObjectToFileUsingId(getFileName(index<255), index, fileDoc);