Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

segment drawing robustness improvements

Browse Source 
* segment::fill() is also called outside the service loop - make sure that size is always calculated correctly
* leave _currentSeg in a meaningful state after strip.service()
This commit is contained in:
Frank
2025-12-21 23:08:50 +01:00
parent b9e7621cd6
commit 577d80d2ef
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wled00/FX_fcn.cpp
View File

@@ -1443,8 +1443,9 @@ void Segment::refreshLightCapabilities() {
void __attribute__((hot)) Segment::fill(uint32_t c) { void __attribute__((hot)) Segment::fill(uint32_t c) {
if (!isActive()) return; // not active if (!isActive()) return; // not active
const uint_fast16_t cols = is2D() ? virtualWidth() : virtualLength(); // WLEDMM use fast int types // WLEDMM use "calc_" functions because fill() is also called from json.cpp without previous seg.startFrame
const uint_fast16_t rows = virtualHeight(); // will be 1 for 1D const uint_fast16_t cols = is2D() ? calc_virtualWidth() : calc_virtualLength(); // WLEDMM use fast int types
const uint_fast16_t rows = calc_virtualHeight(); // will be 1 for 1D
if (is2D()) { if (is2D()) {
// pre-calculate scaled color // pre-calculate scaled color
@@ -2013,6 +2014,9 @@ void WS2812FX::service() {
} }
if (_triggered) doShow = true; // WLEDMM "triggered" always means "show" if (_triggered) doShow = true; // WLEDMM "triggered" always means "show"
#ifdef WLEDMM_FASTPATH
_currentSeg = & strip.getMainSegment(); // WLEDMM safe default
#endif
_virtualSegmentLength = 0; _virtualSegmentLength = 0;
busses.setSegmentCCT(-1); busses.setSegmentCCT(-1);
if(doShow) { if(doShow) {