From 53130f721657d8ccedc0c420797fcafdf1cfd5c5 Mon Sep 17 00:00:00 2001
From: Frank <91616163+softhack007@users.noreply.github.com>
Date: Sun, 16 Nov 2025 13:28:28 +0100
Subject: [PATCH] conditional USB mode: first check build_unflags

* build_unflags have priority over build_flags, so we first check if the flag is already "unflaged"
This finally seems to catch all cases properly :)
---
 pio-scripts/conditional_usb_mode.py | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/pio-scripts/conditional_usb_mode.py b/pio-scripts/conditional_usb_mode.py
index 738a3afa..cb737300 100644
--- a/pio-scripts/conditional_usb_mode.py
+++ b/pio-scripts/conditional_usb_mode.py
@@ -29,8 +29,14 @@ def has_cdc_on_boot_enabled(env):
     Returns True if CDC_ON_BOOT=1, False otherwise.
     This is used to identify boards with USB-OTG (native USB) vs UART-to-USB chips.
     """
-    cpp_defines = env.get('CPPDEFINES', [])
+    build_unflags = env.get('BUILD_UNFLAGS', [])
     build_flags = env.get('BUILD_FLAGS', [])
+    cpp_defines = env.get('CPPDEFINES', [])
+
+    # Check in raw build unflags - unflags have priority over flags
+    for unflag in build_unflags:
+        if isinstance(unflag, str) and 'ARDUINO_USB_CDC_ON_BOOT=1' in unflag:
+            return False
     
     # Check in CPPDEFINES
     for define in cpp_defines:
@@ -51,8 +57,13 @@ def has_usb_mode_enabled(env):
     
     Returns True if USB_MODE=1, False otherwise.
     """
-    cpp_defines = env.get('CPPDEFINES', [])
+    build_unflags = env.get('BUILD_UNFLAGS', [])
     build_flags = env.get('BUILD_FLAGS', [])
+    cpp_defines = env.get('CPPDEFINES', [])
+    # Check in raw build unflags - unflags have priority over flags
+    for unflag in build_unflags:
+        if isinstance(unflag, str) and 'ARDUINO_USB_MODE=1' in unflag:
+            return False
     
     # Check in CPPDEFINES
     for define in cpp_defines: