From 52509bab0f0a05defd27f7e2dba3b6ca33c886d0 Mon Sep 17 00:00:00 2001
From: Frank <91616163+softhack007@users.noreply.github.com>
Date: Sat, 16 Nov 2024 18:13:15 +0100
Subject: [PATCH] OTA update improved error  messages

The OTA update class can deliver an error message.

old: "Please check your file and retry"
new: "Could Not Activate The Firmware. (wrong board type?). Please check your file and retry!"
---
 wled00/wled_server.cpp | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/wled00/wled_server.cpp b/wled00/wled_server.cpp
index f3fe1c08..6bd577d7 100644
--- a/wled00/wled_server.cpp
+++ b/wled00/wled_server.cpp
@@ -329,7 +329,15 @@ void initServer()
       return;
     }
     if (Update.hasError() || otaLock) {
+#ifdef ARDUINO_ARCH_ESP32
+      if (Update.hasError()) {
+        String updErr = Update.getError() == UPDATE_ERROR_ACTIVATE ? String("Could Not Activate The Firmware. (wrong board type?)") : String(Update.errorString());
+        serveMessage(request, 500, F("Update failed!"), updErr + String("<br>Please check your file and retry!"), 254);
+      } else
+        serveMessage(request, 500, F("Update failed!"), F("Please check your file and retry! (OTA may be locked)"), 254);
+#else
       serveMessage(request, 500, F("Update failed!"), F("Please check your file and retry!"), 254);
+#endif
     } else {
       serveMessage(request, 200, F("Update successful!"), F("Rebooting..."), 131);
       doReboot = true;