From 50bb4d29101dcb5f78dd05049751bd16bcbe637f Mon Sep 17 00:00:00 2001 From: Frank <91616163+softhack007@users.noreply.github.com> Date: Tue, 17 Feb 2026 15:49:38 +0100 Subject: [PATCH] I2S_USE_16BIT_SAMPLES does not work add build error, as the 16bit code does not work any more in esp-idf v4.x --- usermods/audioreactive/audio_source.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/usermods/audioreactive/audio_source.h b/usermods/audioreactive/audio_source.h index 35c3564e..a9df6d69 100644 --- a/usermods/audioreactive/audio_source.h +++ b/usermods/audioreactive/audio_source.h @@ -71,6 +71,9 @@ constexpr i2s_port_t AR_I2S_PORT = I2S_NUM_0; // I2S port to use (do not c //#endif #ifdef I2S_USE_16BIT_SAMPLES +#if (ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(4, 2, 0)) // see https://github.com/MoonModules/WLED-MM/issues/333#issuecomment-3910779668 +#error "16bit sampling currently does not work with newer framework versions. Please build without I2S_USE_16BIT_SAMPLES" +#endif #define I2S_SAMPLE_RESOLUTION I2S_BITS_PER_SAMPLE_16BIT #define I2S_datatype int16_t #define I2S_unsigned_datatype uint16_t