From 3c4d71369b7e8d5fe41a5f6159a1db0efa6184f7 Mon Sep 17 00:00:00 2001 From: Frank <91616163+softhack007@users.noreply.github.com> Date: Sat, 16 Nov 2024 19:13:10 +0100 Subject: [PATCH] OTA error code for WLEDMM_SAVE_FLASH reduces program size by ~200 bytes --- wled00/wled_server.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/wled00/wled_server.cpp b/wled00/wled_server.cpp index 6bd577d7..b6e786e6 100644 --- a/wled00/wled_server.cpp +++ b/wled00/wled_server.cpp @@ -331,7 +331,12 @@ void initServer() if (Update.hasError() || otaLock) { #ifdef ARDUINO_ARCH_ESP32 if (Update.hasError()) { - String updErr = Update.getError() == UPDATE_ERROR_ACTIVATE ? String("Could Not Activate The Firmware. (wrong board type?)") : String(Update.errorString()); + #if defined(WLEDMM_SAVE_FLASH) + // not requesting the error string reduces flash size by 200 bytes + String updErr = Update.getError() == UPDATE_ERROR_ACTIVATE ? String("Could Not Activate The Firmware. (wrong board type?)") : String("Error ") + String(Update.getError()); + #else + String updErr = Update.getError() == UPDATE_ERROR_ACTIVATE ? String("Could Not Activate The Firmware. (wrong board type?)") : String(Update.errorString()); + #endif serveMessage(request, 500, F("Update failed!"), updErr + String("
Please check your file and retry!"), 254); } else serveMessage(request, 500, F("Update failed!"), F("Please check your file and retry! (OTA may be locked)"), 254);