Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Removed check for WLEDMM_SLOWPATH as it breaks WLEDMM_SLOWPATH

Browse Source 
Seemingly this breaks WLEDMM_SLOWPATH, which forces RMT for all channels to reduce glitching in big installations. This check actually makes the glitching much worse versus completely fixed in these situations, for reasons I don't fully understand yet.
This commit is contained in:
Troy
2024-05-11 12:37:39 -04:00
committed by GitHub
parent 2144613423
commit 250000de08
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wled00/bus_wrapper.h
View File

@@ -390,7 +390,7 @@ class PolyBus {
};
static void* create(uint8_t busType, uint8_t* pins, uint16_t len, uint8_t channel, uint16_t clock_kHz = 0U) {
#if defined(ARDUINO_ARCH_ESP32) && !(defined(CONFIG_IDF_TARGET_ESP32S2) || defined(CONFIG_IDF_TARGET_ESP32S3) || defined(CONFIG_IDF_TARGET_ESP32C3))
#if defined(WLEDMM_FASTPATH) && !defined(WLEDMM_SLOWPATH) // WLEDMM only for fastpath builds
#if defined(WLEDMM_FASTPATH) // && !defined(WLEDMM_SLOWPATH) // WLEDMM only for fastpath builds. TroyHacks: Removed the WLEDMM_SLOWPATH as it breaks WLEDMM_SLOWPATH
// NOTE: "channel" is only used on ESP32 (and its variants) for RMT channel allocation
// since 0.15.0-b3 I2S1 is favoured for classic ESP32 and moved to position 0 (channel 0) so we need to subtract 1 for correct RMT allocation
if (channel > 0) channel--; // accommodate I2S1 which is used as 1st bus on classic ESP32