Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bugfix #2 for switched-off segments

Browse Source 
segments that are "off" were still rendered during transitions.
This commit is contained in:
Frank
2024-12-03 16:04:21 +01:00
parent 9922d2aa8d
commit 23d41e66c9
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wled00/FX.h
View File

@@ -380,6 +380,7 @@ typedef struct Segment {
}; };
uint8_t grouping, spacing; uint8_t grouping, spacing;
uint8_t opacity; uint8_t opacity;
uint8_t lastBri; // WLEDMM optimization for black-to-black "transitions"
bool needsBlank; // WLEDMM indicates that Segment needs to be blanked (due to change of mirror / reverse / transpose / spacing) bool needsBlank; // WLEDMM indicates that Segment needs to be blanked (due to change of mirror / reverse / transpose / spacing)
uint32_t colors[NUM_COLORS]; uint32_t colors[NUM_COLORS];
uint8_t cct; //0==1900K, 255==10091K uint8_t cct; //0==1900K, 255==10091K
@@ -490,6 +491,7 @@ typedef struct Segment {
grouping(1), grouping(1),
spacing(0), spacing(0),
opacity(255), opacity(255),
lastBri(255),
needsBlank(false), needsBlank(false),
colors{DEFAULT_COLOR,BLACK,BLACK}, colors{DEFAULT_COLOR,BLACK,BLACK},
cct(127), cct(127),

2
wled00/FX_fcn.cpp
View File

@@ -1935,6 +1935,7 @@ void WS2812FX::service() {
now = millis() + timebase; now = millis() + timebase;
#endif #endif
seg.startFrame(); // WLEDMM seg.startFrame(); // WLEDMM
if (!_triggered && (seg.currentBri(seg.opacity) == 0) && (seg.lastBri == 0)) continue; // WLEDMM skip totally black segments
// effect blending (execute previous effect) // effect blending (execute previous effect)
// actual code may be a bit more involved as effects have runtime data including allocated memory // actual code may be a bit more involved as effects have runtime data including allocated memory
//if (seg.transitional && seg._modeP) (*_mode[seg._modeP])(progress()); //if (seg.transitional && seg._modeP) (*_mode[seg._modeP])(progress());
@@ -1944,6 +1945,7 @@ void WS2812FX::service() {
if (seg.mode != FX_MODE_HALLOWEEN_EYES) seg.call++; if (seg.mode != FX_MODE_HALLOWEEN_EYES) seg.call++;
if (seg.transitional && frameDelay > FRAMETIME) frameDelay = FRAMETIME; // force faster updates during transition if (seg.transitional && frameDelay > FRAMETIME) frameDelay = FRAMETIME; // force faster updates during transition
seg.lastBri = seg.currentBri(seg.on ? seg.opacity:0); // WLEDMM remember for next time
seg.handleTransition(); seg.handleTransition();
} }