Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

cleanup - removed old code in comments

Browse Source
This commit is contained in:
Frank
2025-10-25 16:55:52 +02:00
committed by GitHub
parent f78edc43dc
commit 12b3bedba7
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
wled00/util.cpp
View File

@@ -342,10 +342,7 @@ uint8_t extractModeSlider(uint8_t mode, uint8_t slider, char *dest, uint8_t maxL
} else { } else {
// WLEDMM bugfix for WLED-MM #272 // WLEDMM bugfix for WLED-MM #272
// names.substring(...).c_str() returns a pointer to a temporary; it’s invalid by the next statement. Added result buffer "sub" to avoid use-after-free // names.substring(...).c_str() returns a pointer to a temporary; it’s invalid by the next statement. Added result buffer "sub" to avoid use-after-free
// if (nameEnd<0) tmpstr = names.substring(nameBegin).c_str(); // did not find ",", last name? String sub = (nameEnd<0) ? names.substring(nameBegin) : names.substring(nameBegin, nameEnd); // special handling in case we did not find "," (last name)
// else tmpstr = names.substring(nameBegin, nameEnd).c_str();
// strlcpy(dest, tmpstr, maxLen); // copy the name into buffer (replacing previous)
String sub = (nameEnd<0) ? names.substring(nameBegin) : names.substring(nameBegin, nameEnd);
strlcpy(dest, sub.c_str(), maxLen); // copy the name into buffer (replacing previous) strlcpy(dest, sub.c_str(), maxLen); // copy the name into buffer (replacing previous)
} }
} }