Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

8266: fix flickering during file write (experimental)

Browse Source 
8266 also has problems - file.close() will stall interrupts, so we need to wait a bit until leds were updated
This commit is contained in:
Frank
2026-03-21 20:37:53 +01:00
parent afb383d0a2
commit 11b9b6529c
1 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
wled00/file.cpp
View File

@@ -50,13 +50,21 @@ void closeFile() {
if (!f) {doCloseFile = false; return;} // WLEDMM only do all this hick-hack when f is an open file if (!f) {doCloseFile = false; return;} // WLEDMM only do all this hick-hack when f is an open file
bool oldLock = suspendStripService; bool oldLock = suspendStripService;
#if defined(WLEDMM_FILEWAIT) // only wait if we don't have the flicker-free RMTHI driver #if defined(WLEDMM_FILEWAIT) || !defined(ARDUINO_ARCH_ESP32) // only wait if we don't have the flicker-free RMTHI driver
unsigned long t_wait = millis(); unsigned long t_wait = millis();
if (strip.isUpdating()) suspendStripService = true; // WLEDMM schedule short pause to prevent LEDs glitching during flash write if (strip.isUpdating()) suspendStripService = true; // WLEDMM schedule short pause to prevent LEDs glitching during flash write
while(strip.isUpdating() && (millis() - t_wait < 72)) delay(1); // WLEDMM try to catch a moment when strip is idle #if defined(ARDUINO_ARCH_ESP32)
while(strip.isUpdating() && (millis() - t_wait < 96)) delay(0); // try harder while(strip.isUpdating() && (millis() - t_wait < 72)) delay(1); // WLEDMM try to catch a moment when strip is idle
//if (strip.isUpdating()) USER_PRINTLN("closeFile: strip still updating."); while(strip.isUpdating() && (millis() - t_wait < 96)) delay(0); // try harder
delay(2); // might help //if (strip.isUpdating()) USER_PRINTLN("closeFile: strip still updating.");
delay(2); // might help
#else // 8266: only wait in case that can_yield() tells us we can yield and delay
if (can_yield()) {
yield();
while(strip.isUpdating() && (millis() - t_wait < 96)) delay(1);
yield(); // might help
}
#endif
#endif #endif
#else #else
bool oldLock = suspendStripService; // fix build f***u* on 8266 bool oldLock = suspendStripService; // fix build f***u* on 8266