From 10c416338c4c9a00132ccf85a2e474935667db93 Mon Sep 17 00:00:00 2001
From: Frank <91616163+softhack007@users.noreply.github.com>
Date: Fri, 28 Jul 2023 10:39:50 +0200
Subject: [PATCH] avoid spurious "assert" crashes inside wifi core

Builds with the "standard" V3.x platform core showed random assert crashes, so lets ignore espressif and bring back `-D NDEBUG`
---
 platformio.ini | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/platformio.ini b/platformio.ini
index a8db8f4c..839d70c3 100644
--- a/platformio.ini
+++ b/platformio.ini
@@ -161,7 +161,8 @@ build_flags =
   -DSECURE_CLIENT=SECURE_CLIENT_BEARSSL
   -DBEARSSL_SSL_BASIC
   -D CORE_DEBUG_LEVEL=0
-  ;-D NDEBUG  ;; WLEDMM espressif docs say NDEBUG is not recommended. see https://docs.espressif.com/projects/esp-idf/en/v4.4.4/esp32/api-guides/performance/speed.html#not-recommended
+  ;; WLEDMM espressif docs say NDEBUG is not recommended. see https://docs.espressif.com/projects/esp-idf/en/v4.4.4/esp32/api-guides/performance/speed.html#not-recommended
+  -D NDEBUG  ;; however it  seems neecessary for non-V4 builds, to avoid spurious "assert" crashes inside the wifi core.
   -Wno-attributes ;; silence warnings about unknown attribute 'maybe_unused' in NeoPixelBus
   #build_flags for the IRremoteESP8266 library (enabled decoders have to appear here)
   -D _IR_ENABLE_DEFAULT_=false