From 0a826f10ad85580f3d2c9eba2b1e10654654b8c6 Mon Sep 17 00:00:00 2001
From: Frank <frank.moehle@outlook.de>
Date: Thu, 25 May 2023 21:38:08 +0200
Subject: [PATCH] small debug improvements

- don't set -DNDEBUG -> this flag is "not recommended"
- minor change in deserializeMap() WLED_DEBUG code
---
 platformio.ini    | 3 ++-
 wled00/FX_fcn.cpp | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/platformio.ini b/platformio.ini
index 75014436..4c32f7c3 100644
--- a/platformio.ini
+++ b/platformio.ini
@@ -146,7 +146,7 @@ build_flags =
   -DSECURE_CLIENT=SECURE_CLIENT_BEARSSL
   -DBEARSSL_SSL_BASIC
   -D CORE_DEBUG_LEVEL=0
-  -D NDEBUG
+  ;-D NDEBUG  ;; WLEDMM espressif docs say NDEBUG is not recommended. see https://docs.espressif.com/projects/esp-idf/en/v4.4.4/esp32/api-guides/performance/speed.html#not-recommended
   #build_flags for the IRremoteESP8266 library (enabled decoders have to appear here)
   -D _IR_ENABLE_DEFAULT_=false
   -D DECODE_HASH=true
@@ -973,6 +973,7 @@ build_flags =
 
 [Debug_Flags]
 build_flags = 
+  -DDEBUG=1 ;; enable some debug assertions in the platform core
   -D WLED_DEBUG ; lots of generic debug messages
   -D SR_DEBUG ; some extra debug messages from audioreactive
   ; -D MIC_LOGGER ; for sound input monitoring & debugging (use arduino serial plotter)
diff --git a/wled00/FX_fcn.cpp b/wled00/FX_fcn.cpp
index 30c1ac8d..05f298a5 100644
--- a/wled00/FX_fcn.cpp
+++ b/wled00/FX_fcn.cpp
@@ -2186,9 +2186,9 @@ bool WS2812FX::deserializeMap(uint8_t n) {
 
     #ifdef WLED_DEBUG
       DEBUG_PRINTF("Custom ledmap: %d\n", loadedLedmap);
-      for (uint16_t i=0; i<customMappingSize; i++) {
-        if (!(i%Segment::maxWidth)) DEBUG_PRINTLN();
-        DEBUG_PRINTF("%4d,", customMappingTable[i]);
+      for (uint16_t j=0; j<customMappingSize; j++) { // fixing a minor warning: declaration of 'i' shadows a previous local
+        if (!(j%Segment::maxWidth)) DEBUG_PRINTLN();
+        DEBUG_PRINTF("%4d,", customMappingTable[j]);
       }
       DEBUG_PRINTLN();
     #endif