Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

avoid updating strip / segments while draving effects (ESP32 only)

Browse Source 
💫 this is the way🌟
A new locking mechanism that allows to wait until strip.service() has completed.
This commit is contained in:
Frank
2023-06-01 17:41:36 +02:00
parent e99874159d
commit 0a5bfb656d
7 changed files with 100 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
wled00/set.cpp
View File

@@ -21,6 +21,15 @@ void handleSettingsSet(AsyncWebServerRequest *request, byte subPage)
//0: menu 1: wifi 2: leds 3: ui 4: sync 5: time 6: sec 7: DMX 8: usermods 9: N/A 10: 2D
if (subPage <1 || subPage >10 || !correctPIN) return;
// WLEDMM: before changing bus or strip settings, make sure our strip is _not_ servicing effects in parallel
if ((subPage == 2) || (subPage == 10)) {
suspendStripService = true; // temporarily lock out strip updates
if (strip.isServicing()) {
USER_PRINTLN(F("handleSettingsSet(): strip is still drawing effects, waiting ..."));
strip.waitUntilIdle();
}
}
//WIFI SETTINGS
if (subPage == 1)
{
@@ -766,6 +775,10 @@ void handleSettingsSet(AsyncWebServerRequest *request, byte subPage)
}
#endif
if ((subPage == 2) || (subPage == 10)) {
suspendStripService = false; // WLEDMM release lock
}
lastEditTime = millis();
if (subPage != 2 && !doReboot) doSerializeConfig = true; //serializeConfig(); //do not save if factory reset or LED settings (which are saved after LED re-init)
#ifndef WLED_DISABLE_ALEXA
@@ -802,6 +815,12 @@ bool handleSet(AsyncWebServerRequest *request, const String& req, bool apply)
}
}
// WLEDMM: before changing segment settings, make sure our strip is _not_ servicing effects in parallel
if (strip.isServicing()) {
USER_PRINTLN(F("handleSet(): strip is still drawing effects, waiting ..."));
strip.waitUntilIdle();
}
Segment& selseg = strip.getSegment(selectedSeg);
pos = req.indexOf(F("SV=")); //segment selected
if (pos > 0) {