From 05fb246af9e4d87bcb61b92312124f15023f6031 Mon Sep 17 00:00:00 2001 From: Frank <91616163+softhack007@users.noreply.github.com> Date: Mon, 12 Jan 2026 19:40:22 +0100 Subject: [PATCH] small optimization * moved newStart and newEnd calculations into lower scope (``if (newBus->isOk())``) * removed duplicate nullptr check --- wled00/bus_manager.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/wled00/bus_manager.cpp b/wled00/bus_manager.cpp index 96e38ae8..fbe78898 100644 --- a/wled00/bus_manager.cpp +++ b/wled00/bus_manager.cpp @@ -1295,14 +1295,13 @@ int BusManager::add(BusConfig &bc) { Bus *newBus = busses[numBusses]; if (newBus == nullptr) return numBusses; // WLEDMM early exit if bus creation failed - - unsigned newStart = newBus->getStart(); - unsigned newLen = newBus->getLength(); - unsigned newEnd = (newLen > 0) ? newStart + newLen - 1 : newStart; // handle zero-length edge case (only happens when bus could not initialize) // WLEDMM check if added bus overlaps with any existing bus bool foundOverlap = false; unsigned busCount = getNumBusses(); - if (newBus != nullptr && newBus->isOk()) { + if (newBus->isOk()) { + unsigned newStart = newBus->getStart(); + unsigned newLen = newBus->getLength(); + unsigned newEnd = (newLen > 0) ? newStart + newLen - 1 : newStart; // handle zero-length edge case (only happens when bus could not initialize) for (unsigned i=0; i