Jan/WLED_MM_Infinity
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ripple effects: bugfix for 1D

Browse Source 
ripple effects were showing random crashes in 1D mode.
Root cause: negative and out-of-range index passed to getPixelColor(i, col).
This commit is contained in:
Frank
2023-07-26 13:03:58 +02:00
parent 90c4868c28
commit 03de8ac0ad
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
wled00/FX.cpp
View File

@@ -2422,12 +2422,14 @@ uint16_t ripple_base()
} else } else
#endif #endif
{ {
int16_t left = rippleorigin - propI -1; int left = rippleorigin - propI -1;
for (int16_t v = left; v < left +4; v++) { for (int v = left; v < left +4; v++) {
uint8_t mag = scale8(cubicwave8((propF>>2)+(v-left)*64), amp); uint8_t mag = scale8(cubicwave8((propF>>2)+(v-left)*64), amp);
SEGMENT.setPixelColor(v, color_blend(SEGMENT.getPixelColor(v), col, mag)); // TODO if ((v >= 0) && (v < SEGLEN)) // WLEDMM bugfix: v and w can be negative or out-of-range
int16_t w = left + propI*2 + 3 -(v-left); SEGMENT.setPixelColor(v, color_blend(SEGMENT.getPixelColor(v), col, mag)); // TODO
SEGMENT.setPixelColor(w, color_blend(SEGMENT.getPixelColor(w), col, mag)); // TODO int w = left + propI*2 + 3 -(v-left);
if ((v >= 0) && (v < SEGLEN)) // WLEDMM bugfix: v and w can be negative or out-of-range
SEGMENT.setPixelColor(w, color_blend(SEGMENT.getPixelColor(w), col, mag)); // TODO
} }
} }
ripplestate += rippledecay; ripplestate += rippledecay;